fix: stamp update-check cooldown only after a successful fetch - #321

chore: sync fork with upstream (v2.5.5, chattymin#321–chattymin#429)

Upstream chattymin#321 made a check return immediately while another was running.
Here that regressed manual checks: pressing Check now in Settings while a
popover-triggered lookup was in flight returned at once and showed "up to
date" until the first lookup finished (up to 15 s on a slow network). On
main, a manual check always waited for its own lookup. Keep the in-flight
Task and have overlapping callers await it, so there is still one fetch and
every caller sees its result. testOverlappingChecksShareOneFetch now fails
on the early return; the failed-then-retry case moved to its own test.

Also remove AppLog.flush(): since the chattymin#174 port, production uses only
writeAndFlush.

#21)

* fix: stop a second instance from appearing when the login agent is registered (upstream chattymin#163)

The login item is an SMAppService agent whose plist sets RunAtLoad, so
registering it while the app runs makes launchd exec the binary again.
LaunchServices' duplicate-launch protection does not cover a direct exec,
so turning on "Launch at login" left two menu bar icons, and both
instances wrote player-state.json.

At launch, the later instance yields (ordered by the kernel's p_starttime;
launchDate is nil for launchd-exec'd processes) before the status item and
before CrashReporter.install, so the yielding instance cannot clear the
crash marker. Missing or tied start times never yield.

Fork changes: the legacy login-item migration path does not exist here;
an extra test pins the guard's position before CrashReporter.install
(mutation-checked); e2e.sh asserts a single instance.

* fix: flush AppLog on the willTerminate exit path (upstream chattymin#174)

AppKit posts willTerminate and then exits, so markClean's async
"clean shutdown" line was usually lost. AppLog now writes through an
injectable AsyncLineLog backend, and exit paths (markClean, the duplicate
instance yield) use AppLog.writeAndFlush, which drains the queue before
returning. The bundled-app write guard stays, so tests never touch the
real log.

Fork change: AppLogTests' functionBody helper now stops at the nearest
boundary. Upstream preferred the next `func` over the next `///`, so with
the fork's member order the scanned body ran into writeIfChanged and
failed on its legitimate write(message) call. The routing guard still
fails when writeAndFlush is rewritten as write()+flush() (checked).

* fix: wait for the app's PID instead of its name in the update loop (upstream chattymin#175)

The detached upgrade script waited with 'pgrep -x PokeDexBar', which matches
any instance by name. With a duplicate instance running it always ran out
the 20 s wait and then swapped the bundle under a live app. Pass the
terminating PID as $3 and wait with 'kill -0'. The script body is now a
static constant so tests can pin it; a fork-only assertion checks that it
upgrades this app's cask.

* fix: read a trailing zero as ending in a consonant for Korean particles

Josa's digit table left out 0, so a number ending in 0 took the
no-final-consonant particle ("#20가", "v1.19.0를"). However it is read
(영, 십, 백, 천, 만), a trailing zero ends in a consonant. Found while
porting the skipped-version copy; the digit test never covered 0.

* fix: show a skipped release in Settings instead of "up to date" (upstream chattymin#311)

The banner button said "Later" but permanently skipped that version, so
Check now then claimed the installed build was the latest. The button now
reads "Skip this version"; a skipped release is kept as `skipped`, and
Settings says so, with "Show again" and an Update button that installs it.
UpdateChecker takes injected UserDefaults so tests do not touch the real
skip key. Strings are ko/en/ja only; the Korean copy picks its particle
from the version.

* fix: stamp the update-check cooldown only after a validated release (upstream chattymin#321)

check() stamped lastChecked before fetching, so one failed lookup (network,
bad response, unsafe URL) blocked the next attempt for 30 minutes. Record the
cooldown only when the release has a trusted github.com URL and a plain
MAJOR.MINOR.PATCH tag; malformed and prerelease tags count as failed checks.
An in-flight guard keeps overlapping popover opens to one fetch. The fetch is
injectable so tests never hit the network. Upstream's stray default.profraw
is not ported.

* fix: let an overlapping update check wait for the one in flight (review)

Upstream chattymin#321 made a check return immediately while another was running.
Here that regressed manual checks: pressing Check now in Settings while a
popover-triggered lookup was in flight returned at once and showed "up to
date" until the first lookup finished (up to 15 s on a slow network). On
main, a manual check always waited for its own lookup. Keep the in-flight
Task and have overlapping callers await it, so there is still one fetch and
every caller sees its result. testOverlappingChecksShareOneFetch now fails
on the early return; the failed-then-retry case moved to its own test.

Also remove AppLog.flush(): since the chattymin#174 port, production uses only
writeAndFlush.

---------

Co-authored-by: 이동기 <ldg0831@midasin.com>

Port macOS chattymin#321: a failed fetch, unsafe URL, malformed or prerelease tag
no longer starts the 30-minute cooldown, so the next popover open
retries right away. Prerelease tags such as v2.6.0-beta.1 compare equal
to their release under IsNewer, so they are neither applied nor counted
as checked. An in-flight guard keeps overlapping checks on one fetch.